https://bugzilla.redhat.com/show_bug.cgi?id=2119983 --- Comment #35 from Frank Crawford <frank@xxxxxxxxxxxxxxxxxx> --- @negativo17@xxxxxxxxx I've been through the full review process and found two items that I'd say are "Fail" but are also easily fixed. > Patches link to upstream bugs/comments/lists or are otherwise justified. This really just needs a comment in the spec file. > Package should not use obsolete m4 macros This one comes up from the automated tests in FedoraReview, and I think is easiest to fix by doing a PR for upstream. There are also a couple of other rpmlint issues that I noted: > c-icap.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/c-icap.conf This is really just that while you install the tmpfile, it isn't invoked during the install, so the directory won't be invoked until the next reboot. There is a %tmpfiles_create macro for use in %post that should fix this. > c-icap-devel.x86_64: E: incorrect-fsf-address /usr/include/c_icap/txtTemplate.h For this I'd log an issue upstream and leave it at that. > c-icap.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/sbin/c-icap Again, I'd log it as an issue upstream and leave it at that. For the other rpmlint errors, they are not relevant (non-standard-uid/gid and non-standard-dir-perm) or the dependencies are covered by other modules and I should be able to zap them in a .rpmlintrc file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2119983 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
