https://bugzilla.redhat.com/show_bug.cgi?id=2157646 Jonathan Wright <jonathan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jonathan@almalinu |needinfo?(alexandre.detiste |x.org) |@gmail.com) --- Comment #25 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/apt-cacher-ng See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 4-Clause License". 250 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/apt-cacher-ng/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /etc/default [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/default [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 266240 bytes in 14 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in apt-cacher-ng [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [!]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debian_release 1 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: apt-cacher-ng-3.7.4-1.fc38.x86_64.rpm apt-cacher-ng-debuginfo-3.7.4-1.fc38.x86_64.rpm apt-cacher-ng-debugsource-3.7.4-1.fc38.x86_64.rpm apt-cacher-ng-3.7.4-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp65x4cq_l')] checks: 31, packages: 4 apt-cacher-ng.x86_64: W: non-standard-uid /run/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-uid /var/cache/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-uid /var/log/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-gid /run/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-gid /var/cache/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-gid /var/log/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: E: executable-marked-as-config-file /etc/cron.daily/apt-cacher-ng 4 packages and 0 specfiles checked; 1 errors, 6 warnings, 1 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: apt-cacher-ng-debuginfo-3.7.4-1.fc38.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7d8vdr5g')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 apt-cacher-ng.x86_64: W: non-standard-uid /run/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-uid /var/cache/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-uid /var/log/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-gid /run/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-gid /var/cache/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: W: non-standard-gid /var/log/apt-cacher-ng apt-cacher-ng apt-cacher-ng.x86_64: E: executable-marked-as-config-file /etc/cron.daily/apt-cacher-ng 3 packages and 0 specfiles checked; 1 errors, 6 warnings, 1 badness; has taken 1.2 s Source checksums ---------------- http://ftp.debian.org/debian/pool/main/a/apt-cacher-ng/apt-cacher-ng_3.7.4-1.debian.tar.xz : CHECKSUM(SHA256) this package : 84bb67be5a6a77f1d412ea3b55fd6ae36f9434e42536391776c8083b6fc07e69 CHECKSUM(SHA256) upstream package : 84bb67be5a6a77f1d412ea3b55fd6ae36f9434e42536391776c8083b6fc07e69 http://ftp.debian.org/debian/pool/main/a/apt-cacher-ng/apt-cacher-ng_3.7.4.orig.tar.xz : CHECKSUM(SHA256) this package : 63140473a669c42f5e2219e38fa9d7c733f9047699dde52c3bd828e372929a5f CHECKSUM(SHA256) upstream package : 63140473a669c42f5e2219e38fa9d7c733f9047699dde52c3bd828e372929a5f Requires -------- apt-cacher-ng (rpmlib, GLIBC filtered): /bin/sh /usr/bin/perl /usr/bin/sh config(apt-cacher-ng) crontabs ld-linux-x86-64.so.2()(64bit) libbz2.so.1()(64bit) libc.so.6()(64bit) libcares.so.2()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libevent-2.1.so.7()(64bit) libevent_pthreads-2.1.so.7()(64bit) libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.2)(64bit) libfuse.so.2(FUSE_2.6)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblzma.so.5()(64bit) liblzma.so.5(XZ_5.0)(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsupacng.so.1()(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) logrotate perl rtld(GNU_HASH) systemd xz apt-cacher-ng-debuginfo (rpmlib, GLIBC filtered): apt-cacher-ng-debugsource (rpmlib, GLIBC filtered): Provides -------- apt-cacher-ng: apt-cacher-ng apt-cacher-ng(x86-64) config(apt-cacher-ng) group(apt-cacher-ng) libsupacng.so.1()(64bit) user(apt-cacher-ng) apt-cacher-ng-debuginfo: apt-cacher-ng-debuginfo apt-cacher-ng-debuginfo(x86-64) debuginfo(build-id) libsupacng.so.3.7.4-3.7.4-1.fc38.x86_64.debug()(64bit) apt-cacher-ng-debugsource: apt-cacher-ng-debugsource apt-cacher-ng-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name apt-cacher-ng --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Perl, C/C++, Shell-api, Generic Disabled plugins: SugarActivity, PHP, Python, R, Java, fonts, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: ======================= I think a few things got missed that I cited before: > %patch0 -p1 This is not needed. Simply change: > %setup -q to > %autosetup -p1 and it will handle the patching for you. You can also drop the "0" from "Patch0" when defining it if you want. > Patch0: supacng.patch Add a comment about what the patch is doing (versioning the shared library). > apt-cacher-ng.x86_64: E: executable-marked-as-config-file /etc/cron.daily/apt-cacher-ng This remaining rpmlint error needs to be ignored via the rpmlintrc. ----- Since you are packaging the Perl scripts with it we need a proper Requires per packaging policy [1]: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2157646 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
