Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtune - standard API to access the kernel tunables https://bugzilla.redhat.com/show_bug.cgi?id=210007 ------- Additional Comments From konradr@xxxxxxxxxx 2007-12-21 16:36 EST ------- Per http://fedoraproject.org/wiki/Packaging/ReviewGuidelines: 1). "MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task." The SRPM has: 098e787f377632793ec25dc8f208176b libtune-0.14.tar.bz2 While the version from the URL is: 666cc8c413f9f783c2bec5bd37d33cb0 libtune-0.14-1.tar.bz2 Please release upstream the newer version (0.14-2) and as well in the .spec file reference the %{name}-%{version}-%{release}.tar.bz2 2). MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} Currently the .spec file has: Requires: %{name} = %{version} That should be: Requires: %{name} = %{version}-%{release} Please fix those two issues. I've built the package in koji under F8, and F7. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review