https://bugzilla.redhat.com/show_bug.cgi?id=2156237 --- Comment #12 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #11) > For bundled libraries and javascript see: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling I think this statement really helps to hint why I don't think it applies in this situation: All packages whose upstreams allow them to be built against system libraries MUST be built against system libraries. In this case, bundled libraries (and/or their source code) MUST be explicitly deleted during %prep. Build scripts may need to be patched to deal with this situation. Whenever possible, the patch should conditionalize the use of the bundled libraries, so that the patch can be sent upstream for consideration. There is no jquery to delete in the source, no builds to patch to use system libraries, or upstream change to use system libraries. Instead, the package already *is* using system libraries. It provides no jquery, it uses the jquery provided by the Fedora packaged doxygen. Calling this bundled seems more akin to saying libc++ template code is bundled into a compiled C++ application. Also, looking across at other examples as expected the jquery files for doxygen are present in other package already present in my system. Some examples after a quick look, flac-devel, opus-devel, alsa-lib-devel, mpg-123-devel, and more. > https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/ I don't believe this applies in this case, those guidelines even say "Please note that this section really only applies to JavaScript libraries intended for use on the web." This is not targeted at the web. It seems pretty clear to me that this does not constitute a bundled library, and I'm not even sure how or what I would change to make it not bundled as it already pulls the jquery present in the doxygen system package. However, if you still think there is uncertainty, we can definitely bring it up on the devel list to seek clarity and guidance. Let me know what you think needs to happen in order to make you comfortable with the package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2156237 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
