https://bugzilla.redhat.com/show_bug.cgi?id=2150221 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(code@musicinmybra | |in.net) | |needinfo?(code@musicinmybra | |in.net) | --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I’m sorry it’s taken so long to get back to this. The changes look good: --- srpm-unpacked/python-opytimizer.spec 2022-12-01 13:30:05.000000000 -0500 +++ 2150221-python-opytimizer/srpm-unpacked/python-opytimizer.spec 2023-01-05 12:20:23.000000000 -0500 @@ -25,6 +25,10 @@ # PR: https://github.com/gugarosa/opytimizer/pull/33 Patch: 33.patch +# Move development dependencies out from the main dependencies +# PR: https://github.com/gugarosa/opytimizer/pull/34 +Patch: 34.patch + %description %{desc} @@ -65,7 +69,7 @@ %forgeautosetup -p1 %generate_buildrequires -%pyproject_buildrequires -r +%pyproject_buildrequires %build %pyproject_wheel @@ -83,7 +87,7 @@ # despite the use of xvfb, several plots are shown %if %{with tests} -xvfb-run -a python3 -m pytest -k 'not plot' +xvfb-run -a %{python3} -m pytest -k 'not plot' %endif %files -n python3-opytimizer -f %{pyproject_files} And the patch looks reasonable: https://github.com/gugarosa/opytimizer/pull/34/files So does the rpmlint output: Checking: python3-opytimizer-3.1.2-1.fc38.noarch.rpm python-opytimizer-doc-3.1.2-1.fc38.noarch.rpm python-opytimizer-3.1.2-1.fc38.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpn_fz2646')] checks: 31, packages: 3 python-opytimizer.spec: W: patch-not-applied Patch0: 34.patch python-opytimizer-doc.noarch: W: description-shorter-than-summary ================ 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s ================ The first warning is because rpmlint does not understand %forgeautosetup, and the second is not a real problem in this case. I’m therefore going to skip re-posting the full review template. The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2150221 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
