https://bugzilla.redhat.com/show_bug.cgi?id=2157628 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 (SHA-512: 5e0a8c3e0efd4b50a6057e56200735c5457edbc99005cea4620f2b6c095c47b283b62b2d6f06a8ddc2886c9020cb0e32f9fb33c8fd711210c67bc8391fa57bc3) is original. Ok. Summary verified from lib/DateTime/HiRes.pm. Ok. Description verified from lib/DateTime/HiRes.pm. Ok. License verified from dist.ini, lib/DateTime/HiRes.pm, README.md, LICENSE. CODE_OF_CONDUCT.md file is CC-BY-4.0 <https://www.contributor-covenant.org/version/1/4/code-of-conduct/>. FIX: Add CC-BY-4.0 to License tag or remove the file from %files. CONTRIBUTING.md file is based on Dist-Zilla-PluginBundle-DROLSKY-1.09 which is Artistic-2.0, but that license does not impose any real obligations for modified binary distributions (i.e. CONTRIBUTING.md). Hence "GPL-1.0-or-later OR Artistic-1.0-Perl" is fine here. No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-DateTime-HiRes.spec ../SRPMS/perl-DateTime-HiRes-0.04-1.fc38.src.rpm ../RPMS/noarch/perl-DateTime-HiRes-* ======================================== rpmlint session starts ======================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 perl-DateTime-HiRes-tests.noarch: W: no-documentation ========= 3 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ======== rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-DateTime-HiRes-* drwxr-xr-x 2 root root 0 Jan 2 01:00 /usr/share/doc/perl-DateTime-HiRes -rw-r--r-- 1 root root 3243 Jul 27 2020 /usr/share/doc/perl-DateTime-HiRes/CODE_OF_CONDUCT.md -rw-r--r-- 1 root root 3736 Jul 27 2020 /usr/share/doc/perl-DateTime-HiRes/CONTRIBUTING.md -rw-r--r-- 1 root root 316 Jul 27 2020 /usr/share/doc/perl-DateTime-HiRes/Changes -rw-r--r-- 1 root root 1805 Jul 27 2020 /usr/share/doc/perl-DateTime-HiRes/README.md -rw-r--r-- 1 root root 99 Jul 27 2020 /usr/share/doc/perl-DateTime-HiRes/Todo drwxr-xr-x 2 root root 0 Jan 2 01:00 /usr/share/licenses/perl-DateTime-HiRes -rw-r--r-- 1 root root 18355 Jul 27 2020 /usr/share/licenses/perl-DateTime-HiRes/LICENSE -rw-r--r-- 1 root root 1768 Jan 2 01:00 /usr/share/man/man3/DateTime::HiRes.3pm.gz drwxr-xr-x 2 root root 0 Jan 2 01:00 /usr/share/perl5/vendor_perl/DateTime -rw-r--r-- 1 root root 2068 Jul 27 2020 /usr/share/perl5/vendor_perl/DateTime/HiRes.pm drwxr-xr-x 2 root root 0 Jan 2 01:00 /usr/libexec/perl-DateTime-HiRes drwxr-xr-x 2 root root 0 Jan 2 01:00 /usr/libexec/perl-DateTime-HiRes/t -rw-r--r-- 1 root root 2867 Jul 27 2020 /usr/libexec/perl-DateTime-HiRes/t/00-report-prereqs.dd -rwxr-xr-x 1 root root 5919 Jan 2 01:00 /usr/libexec/perl-DateTime-HiRes/t/00-report-prereqs.t -rwxr-xr-x 1 root root 852 Jan 2 01:00 /usr/libexec/perl-DateTime-HiRes/t/now.t -rwxr-xr-x 1 root root 103 Jan 2 01:00 /usr/libexec/perl-DateTime-HiRes/test File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-DateTime-HiRes-0.04-1.fc38.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(DateTime) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 $ rpm -q --requires -p ../RPMS/noarch/perl-DateTime-HiRes-tests-0.04-1.fc38.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 /usr/bin/sh 1 perl(DateTime::HiRes) 1 perl(ExtUtils::MakeMaker) 1 perl(File::Spec) 1 perl(strict) 1 perl(Test::More) 1 perl(Time::HiRes) 1 perl(warnings) 1 perl-DateTime-HiRes = 0.04-1.fc38 1 perl-Test-Harness 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-DateTime-HiRes-0.04-1.fc38.noarch.rpm | sort -f | uniq -c 1 perl(DateTime::HiRes) = 0.04 1 perl-DateTime-HiRes = 0.04-1.fc38 $ rpm -q --provides -p ../RPMS/noarch/perl-DateTime-HiRes-tests-0.04-1.fc38.noarch.rpm | sort -f | uniq -c 1 perl-DateTime-HiRes-tests = 0.04-1.fc38 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-DateTime-HiRes-* Binary dependencies are resolvable. Ok. The package builds in Fedora 38 (https://koji.fedoraproject.org/koji/taskinfo?taskID=95960897). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2157628 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
