https://bugzilla.redhat.com/show_bug.cgi?id=2158464 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo? |fedora-review+ --- Comment #6 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Syntax-Operator-In-0.04-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 ld-linux-x86-64.so.2()(64bit) 1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 perl(Carp) 1 perl-libs 2 perl(:MODULE_COMPAT_5.36.0) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) 1 perl(XSLoader) 1 perl(XS::Parse::Infix) >= 0.27 1 perl(:XS_Parse_Infix_ABI_2) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-Syntax-Operator-In-0.04-1.fc38.x86_64.rpm | sort | uniq -c 1 perl(Syntax::Operator::Elem) = 0.04 1 perl(Syntax::Operator::In) = 0.04 1 perl-Syntax-Operator-In = 0.04-1.fc38 1 perl-Syntax-Operator-In(x86-64) = 0.04-1.fc38 Binary provides are Ok. Rpmlint is ok TODO: Please consider using only one style of defining the rpm Build Root. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags FIX: Add missing 'done' to 'for' on line 73. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2158464 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
