https://bugzilla.redhat.com/show_bug.cgi?id=2153687 --- Comment #6 from John Wass <jwass3@xxxxxxxxx> --- Spec URL: https://github.com/ctc-oss/fapolicy-analyzer/releases/download/v0.6.5/fapolicy-analyzer.spec SRPM URL: https://github.com/ctc-oss/fapolicy-analyzer/releases/download/v0.6.5/fapolicy-analyzer-0.6.5-1.fc38.src.rpm tl;dr; Addressed all findings with exception of the file-not-in-%lang lint, working on that now. Wanted to get another iteration on everything else in the meantime. > [?]: Package contains no bundled libraries without FPC exception. > > What should we do about vendor? Reviewed all dependencies, bumped some versions and cut our tools crate out of the build. Surprisingly, we are down to two missing crates. I will submit a couple bz requests and see if they can be added. (Note: our vendor tarball contains more entries, but many are just stubs to satisfy Cargo metadata) > [?]: Package contains desktop file if it is a GUI application. > > I think this is also relevant ^. Added a desktop file. > [!]: Package meets the Packaging Guidelines::Python > > Please, use macros instead of python3 interpreter. Done > I would also use "tar -xzf" instead of "tar xzf" Done > and "%autosetup -p0" instead of "%autosetup -p1" in .spec My original spec used "-p0", so I wasnt sure if you mistyped or misread or if I am missing it :) Unchanged, will update after getting clarification. > but it's just my personal recomendation. Appreciate the suggestions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2153687 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
