https://bugzilla.redhat.com/show_bug.cgi?id=2121759 Troy Curtis <troy@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- Ah, yeah I see what you mean. I think actually I was probably wrong about the expectation of pytest being in auto detected as a build dep. Since it is a dev dep, not really a build dep (in the context of this project, even if it is for the Fedora package), it doesn't get picked up so I think that it good to leave as is. On the version, needing both tarballs is a bit strange. Perhaps it would be a little more streamlined to just prep the source using this snippet I pulled from the github workflows: RX_VERSION=$(dunamai from any --no-metadata --style pep440) poetry version $RX_VERSION echo "__version__ = \"$RX_VERSION\"" > reactivex/_version.py Where you just use the %{version} macro in for RX_VERSION. The pyproject changes look good. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121759 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
