Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flam3 - Programs to generate and render cosmic recursive fractal flames https://bugzilla.redhat.com/show_bug.cgi?id=417711 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-21 10:27 EST ------- For 2.7.7-2: * Redundant Requires - "Requires: glibc" is really unneeded. * flam3.src:25: W: unversioned-explicit-provides flam3-static (from rpmlint) - Please change to ------------------------------------------------------ Provides: flam3-static = %{version}-%{release} ------------------------------------------------------ * SourceURL - I recommend to use %version macro because with this you probably won't have to change the SourceURL when new version is released. * Timestamps - To keep timestamps on installed files, please use ------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------ While sometimes this does not work, this method usually works for recent Makefiles. * Directory ownership issue ------------------------------------------------------ [tasaka1@localhost ~]$ rpm -qf /usr/share/flam3/flam3-palettes.xml flam3-2.7.7-2.fc9 [tasaka1@localhost ~]$ rpm -qf /usr/share/flam3 file /usr/share/flam3 is not owned by any package ------------------------------------------------------ - This means that * installing flam3 rpm creates %_datadir/flam3 to install xml file, however the created %_datadir/flam3 directory is not owned by any package. ! Note When you write ------------------------------------------------------ %files %{_datadir}/flam3/ ------------------------------------------------------ this includes the directory %_datadir/flam3 and all files/directories/etc under %_datadir/flam3, while ------------------------------------------------------- %files %dir %{_datadir}/flam3/ ------------------------------------------------------- includes the directory %{_datadir}/flam3 only. * Some issues in -devel subpackage - Please check %{_libdir}/pkgconfig/flam3.pc. The content must be fixed. ------------------------------------------------------- Libs: -L${libdir} -lflam3 @WIN32_LIBS@ Cflags: -I@INCLUDEDIR@ @WIN32_CFLAGS@ ------------------------------------------------------- - The following line in flam3.pc ------------------------------------------------------- Requires: libpng12 >= 1.0 ------------------------------------------------------- means that flam3-devel should have "Requires: libpng-devel" - %_includedir/flam3.h contains: ------------------------------------------------------- 24 #include <stdio.h> 25 #include <libxml/parser.h> 26 #include "isaac.h" ------------------------------------------------------- * The line 25 means that flam3-devel should have "libxml2-devel" * And the line 26 is strange because isaac.h is not installed. * Duplicate documents - You don't have to install documents in -devel subpackage which are already added to main package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review