https://bugzilla.redhat.com/show_bug.cgi?id=2157646 --- Comment #21 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- Looks pretty good now. Need to actually have it build the -devel package to fix the unversioned shared lib issue. Ex adding these snippets to your spec should fix it: --- %package devel Summary: Development files for %{name} %description devel %{summary} %files devel %license COPYING %{_libdir}/libsupacng.so --- There are lots of places where I think it would make more sense to use %{name} instead of apt-cacher-ng, ie almost everywhere. > %patch0 -p1 This is not needed. Simply change: > %setup -q to > %autosetup -p1 and it will handle the patching for you. You can also drop the "0" from "Patch0" when defining it if you want. > Patch0: supacng.patch Add a comment about what the patch is doing (versioning the shared library). > apt-cacher-ng.x86_64: E: executable-marked-as-config-file /etc/cron.daily/apt-cacher-ng This remaining rpmlint error needs to be ignored via the rpmlintrc. > Provides: bundled(sha1-hollerbach) > Provides: bundled(md5-deutsch-c++) I'm not sure these are actually bundled anymore. I'm not seeing any signs of them in the sources. I think these lines can be removed. --- Since you are packaging the Perl scripts with it we need a proper Requires per packaging policy [1]: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_versioned_module_compat_requires I think after these fixes we'll be ready to wrap this one up. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2157646 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
