https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #43 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> --- Hey Benson! Happy new year and all that. ;D (In reply to Benson Muite from comment #41) > f) Perhaps ask on Fedora security list: > https://lists.fedoraproject.org/admin/lists/security.lists.fedoraproject.org/ OK. I'll take it into account. I'm waiting on upstream to see if a proposed patch fixes stuff. They're checking. I'll consult with the Fedora Security team afterwards. > Current version fails to build: > In file included from /usr/include/curl/curl.h:3195, > from turnrest.c:21: > turnrest.c: In function 'janus_turnrest_request': > turnrest.c:168:9: error: void value not ignored as it ought to be > 168 | curl_easy_setopt(curl, api_http_get ? CURLOPT_HTTPGET : > CURLOPT_ > POST, 1); > | > > Reported this https://github.com/meetecho/janus-gateway/issues/3131 Thank you, so much, for reporting this. I see they've fixed it and I've taken the patch and applied it. Thanks for the help. > g) Browsers such as Firefox and Chrome seem to ship with a configuration > specifically for Fedora. Maybe we could do the same for janus, have a Fedora > themed demo? I dunno how this will sit with upstream. They seem interested in their industrial design (or whatever that is called). My take would be to focus on packaging as is and, later on, we could ask upstream about this and see what they think. I'm all for it, though. So, spec and SRPM: SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.1-4.fc37.src.rpm I've tested the build with mock; using F37 and F36 profiles. The F37 build finished successfully. The F36 didn't. It reported some "files not found" which is kind of odd since I am using the same SRPM for both (same spec and all). I get this when trying to build on Fedora 36: # mock -r fedora-36-x86_64 ... ... Processing files: janus-doc-1.1.1-4.fc36.noarch error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/bc_sd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000000.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000001.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000002.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000005.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/docd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_fd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_hd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_d.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_seld.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/splitbard.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_ad.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_bd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_hd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_sd.png RPM build errors: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/bc_sd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000000.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000001.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000002.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000005.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/docd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_fd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_hd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag.svg File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_d.svg File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_seld.svg File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/splitbard.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_ad.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_bd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_hd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_sd.png ... Will investigate further. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121585 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
