https://bugzilla.redhat.com/show_bug.cgi?id=2149686 --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 6 files have unknown license. Detailed output of licensecheck in /home/fedora/2149686-hack- fonts/licensecheck.txt [?]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [?]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Checking: hack-fonts-3.003-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplfmnyho1')] checks: 31, packages: 1 hack-fonts.spec:39: W: setup-not-quiet 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/source-foundry/Hack/raw/v3.003/config/fontconfig/45-Hack.conf : CHECKSUM(SHA256) this package : 285aa89a2a90f6bc6422d62cd13889d303903da886e435c6eaa2adef66e25ae6 CHECKSUM(SHA256) upstream package : 285aa89a2a90f6bc6422d62cd13889d303903da886e435c6eaa2adef66e25ae6 https://github.com/source-foundry/Hack/raw/v3.003/README.md : CHECKSUM(SHA256) this package : 249886125a58c914ab83a92659ca4e12c39a40535e9eeca735dd57f123264105 CHECKSUM(SHA256) upstream package : 249886125a58c914ab83a92659ca4e12c39a40535e9eeca735dd57f123264105 https://github.com/source-foundry/Hack/raw/v3.003/LICENSE.md : CHECKSUM(SHA256) this package : 1f61bb7c790c59b4b0ecdf304628b94e42ae4c8020094a8c3da73381ab212623 CHECKSUM(SHA256) upstream package : 1f61bb7c790c59b4b0ecdf304628b94e42ae4c8020094a8c3da73381ab212623 https://github.com/source-foundry/Hack/releases/download/v3.003/Hack-v3.003-ttf.tar.xz : CHECKSUM(SHA256) this package : d9ed5d0a07525c7e7bd587b4364e4bc41021dd668658d09864453d9bb374a78d CHECKSUM(SHA256) upstream package : d9ed5d0a07525c7e7bd587b4364e4bc41021dd668658d09864453d9bb374a78d Requires -------- Provides -------- Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2149686 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic, fonts Disabled plugins: Ocaml, SugarActivity, Java, Haskell, R, C/C++, Python, Perl, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Vendor ID in all cases is SRC for Source Foundry, https://learn.microsoft.com/en-us/typography/vendors/ Maybe the name should be src-hack-fonts? b) Can you add a license breakdown in the spec file? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2149686 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
