https://bugzilla.redhat.com/show_bug.cgi?id=2133080 --- Comment #14 from David Shea <reallylongword@xxxxxxxxx> --- (In reply to Miro Hrončok from comment #12) > Looking at the packaged files. > > ... > /usr/lib64/python3.11/site-packages/nss/NSPRerrs.h > /usr/lib64/python3.11/site-packages/nss/SECerrs.h > /usr/lib64/python3.11/site-packages/nss/SSLerrs.h > ... > /usr/lib64/python3.11/site-packages/nss/py_nspr_common.h > /usr/lib64/python3.11/site-packages/nss/py_nspr_error.c > /usr/lib64/python3.11/site-packages/nss/py_nspr_error.h > /usr/lib64/python3.11/site-packages/nss/py_nspr_io.c > /usr/lib64/python3.11/site-packages/nss/py_nspr_io.h > /usr/lib64/python3.11/site-packages/nss/py_nss.c > /usr/lib64/python3.11/site-packages/nss/py_nss.h > /usr/lib64/python3.11/site-packages/nss/py_shared_doc.h > /usr/lib64/python3.11/site-packages/nss/py_ssl.c > /usr/lib64/python3.11/site-packages/nss/py_ssl.h > /usr/lib64/python3.11/site-packages/nss/py_traceback.h > ... > > > The header files are only for building the extension modules. They aren't useful for another program to build against, so excluding them is the right thing to do. > > If this was established, should the header files be indeed excluded? Aw nerts, misread this one too. I was looking at the F36 package, which doesn't do this. Apparently setuptools changed something since then as far as what files get included. I've added a patch that moves the one python file (__init__.py) into a separate directory so that everything else doesn't get pulled in as part of the python module. > > ... > /usr/share/doc/python3-nss/html/_static/jquery-3.6.0.js > /usr/share/doc/python3-nss/html/_static/jquery.js > ... > /usr/share/doc/python3-nss/html/_static/underscore-1.13.1.js > /usr/share/doc/python3-nss/html/_static/underscore.js > ... > > The documentation bundles jquery and other CSS and JS things. Do you really > need to build it? If so, should it: > > 1) be split to an optional subpackage to avoid installing it alongside a > dependency of other packages > 2) declare all bundled() provides > 3) have a license tag that has the license of the bundled bits in it > > ? > > (I'd simply not build the docs at all instead.) Sure, I'll just remove it. (In reply to Miro Hrončok from comment #13) > Also, the %license files are duplicated (%{pyproject_files} already has > them): > > $ rpm -qlp --licensefiles > Stažené/python3-nss-1.0.1^20210803hg9de14a6f77e2-4.fc38.x86_64.rpm > /usr/lib64/python3.11/site-packages/python_nss-1.0.1.dist-info/LICENSE.gpl > /usr/lib64/python3.11/site-packages/python_nss-1.0.1.dist-info/LICENSE.lgpl > /usr/lib64/python3.11/site-packages/python_nss-1.0.1.dist-info/LICENSE.mpl > /usr/share/licenses/python3-nss/LICENSE.gpl > /usr/share/licenses/python3-nss/LICENSE.lgpl > /usr/share/licenses/python3-nss/LICENSE.mpl So this one seems a little weird. They're getting added to the dist-info automatically, and marked as license files, even if I remove the reference to the files from setup.cfg. But this only happens in rawhide, so f36/f37 will need to do something differently. Any advice? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2133080 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
