https://bugzilla.redhat.com/show_bug.cgi?id=2133080 --- Comment #4 from David Shea <reallylongword@xxxxxxxxx> --- (In reply to Mattia Verga from comment #2) > - Header files in -devel subpackage, if present. > Note: python3-nss : /usr/lib64/python3.11/site-packages/nss/NSPRerrs.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/SECerrs.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/SSLerrs.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/py_nspr_common.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/py_nspr_error.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/py_nspr_io.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/py_nss.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/py_shared_doc.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/py_ssl.h > python3-nss : /usr/lib64/python3.11/site-packages/nss/py_traceback.h > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_devel_packages > [!]: Development files must be in a -devel package > > Need to ask in python-devel mailing list, I've never seen such a situation. The header files are only for building the extension modules. They aren't useful for another program to build against, so excluding them is the right thing to do. The test is mis-interpreting them as something more like a C library. > [!]: License field in the package spec file matches the actual license. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > > You should update the specfile to use SPDX identifier. AFAIK, the license > breakdown > is no more required. I didn't think the SPDX identifiers were ready yet? Based on https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 and the linked tracking bug. I can pare the list down to just MPL though since it's GPL compatible. > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > > This is a SHOULD, can you add comments about applied patches? The patches themselves have git commit messages. And if I'm going to be de facto upstream I could just point the Source URL to my github repo instead and skip the patches. > [!]: Rpmlint is run on all installed packages. > python3-nss.x86_64: W: hidden-file-or-dir > /usr/share/doc/python3-nss/html/.buildinfo > > Weird file in final package. Leftover from sphinx, I'll remove it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2133080 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
