https://bugzilla.redhat.com/show_bug.cgi?id=2156234 --- Comment #5 from Troy Curtis <troy@xxxxxxxxxxxxxxxx> --- I'm glad you pushed on the bundled libraries a bit. It turns out that all but doctest are only used in sandbox/, which appears to be a dumping ground of random code snippets of interest to upstream. Using the system doctest was a trivial change, and all the bundles could go away. I've removed them during the prep step. Additionally, looking more closely at the docs was a good exercise as well. I've put the html and examples into a doc subpackage, which could be useful, but I also looked more closely at the licenses of various PDFs of published papers included in the references section. They range from ambiguous to certainly not OK for Fedora to redistribute (and they may or may not actually be OK for the author to redistribute depending on what documentation they have. I opened an issue upstream to have them clarify the terms https://github.com/taskflow/taskflow/issues/451). Looking at the terms of a few of the IEEE copyright listings, we likely can't even post the source tarball without explicit permission, thus I followed the process described https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code to create a script to generate a tarball without the prohibited content. Updated spec and srpm: https://troycurtisjr.fedorapeople.org/taskflow/taskflow.spec https://troycurtisjr.fedorapeople.org/taskflow/taskflow-3.4.0-3.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2156234 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
