https://bugzilla.redhat.com/show_bug.cgi?id=2094246 --- Comment #3 from Martin Schanzenbach <schanzen@xxxxxxxxxx> --- Hi, in the meantime I have been updating the package for every release and set the COPR build to build with fedora-review. The open issues seem to be: -- - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ => More on this below. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file libgnunet_plugin_rest_copying.so is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text => This is probably a false positive regex match. - systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in gnunet See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units => I have no idea what the "issue" is with this. I followed the user unit guide. => Regarding some of the manual checks: [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/gnunet, /usr/share/doc/gnunet => I tried to get rid of this for hours. I have no idea what the issue is. The directories are declared with %dir. [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libgnunet => So, libgnunet is the subpackage that is basically the core everything else depends upon. => The subpackage itself does not have any local Require's. I cannot get rid of this message. gnunet-doc.noarch: E: files-duplicated-waste 318478 => GNUnet 0.19.2 will fix this hopefully along with some man pages. gnunet.x86_64: E: call-to-mktemp /usr/bin/gnunet-testing gnunet.x86_64: E: call-to-mktemp /usr/lib64/gnunet/libgnunet_plugin_datacache_sqlite.so gnunet.x86_64: E: call-to-mktemp /usr/lib64/libgnunetdatacache.so.0.0.1 gnunet.x86_64: E: call-to-mktemp /usr/lib64/libgnunetfs.so.2.1.1 libgnunet.x86_64: E: call-to-mktemp /usr/lib64/libgnunetutil.so.15.0.0 => This results in 6 errors and does not make sense. The code never calls mktemp. In fact, it only calls mkstemp and mkdtemp: https://git.gnunet.org/gnunet.git/tree/src/util/disk.c#n380 -- I have added my review.txt as attachment. Happy new year. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2094246 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
