[Bug 2119983] Review Request: c-icap - An implementation of an ICAP server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2119983



--- Comment #22 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
There are tests distributed with the code. Maybe some of these should be run in
a %check section?

Using:

./configure --with-perl --with-openssl --with-zlib --with-bzlib --with-ldap
--enable-ipv6 --enable-lib-compat --enable-large-files --without-bdb
--prefix=$HOME/SomeLocation

Then checking
$ ldd --unused perl_handler.so
Unused direct dependencies:
        /lib64/libresolv.so.2
        /lib64/libgdbm.so.6
        /lib64/libdb-5.3.so
        /lib64/libm.so.6
        /lib64/libcrypt.so.2
        /lib64/libgdbm_compat.so.4
        /lib64/libatomic.so.1

Indicates that libdb is linked but is not used.

In particular using
$perl -MConfig -e 'print $Config{libs}'
-lpthread -lresolv -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat

one sees that Perl brings in libdb
https://github.com/c-icap/c-icap-server/blob/master/configure.ac#L348
from
https://src.fedoraproject.org/rpms/perl/blob/rawhide/f/perl.spec#_194

May also want to examine the Perl guidelines to add correct requires for the
Perl subpackage:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_perl_requires_and_provides

An updated spec file is available at:
https://download.copr.fedorainfracloud.org/results/fed500/c-icap/fedora-rawhide-x86_64/05188184-c-icap/c-icap.spec
Corresponding srpm:
https://download.copr.fedorainfracloud.org/results/fed500/c-icap/fedora-rawhide-x86_64/05188184-c-icap/c-icap-0.5.10-6.fc38.src.rpm

Output of Fedora-Review:
https://download.copr.fedorainfracloud.org/results/fed500/c-icap/fedora-rawhide-x86_64/05188184-c-icap/fedora-review/review.txt

It seems logrotate should be required by the main package?  There also seem to
be further linking problems to resolve.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux