https://bugzilla.redhat.com/show_bug.cgi?id=2156603 --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Carl George 🤠 from comment #4) > > This is not a normal desktop file, and is not installed in /usr/share/applications, so it doesn't qualify for validation, IMO. > > The guidelines don't list the path as a criteria for requiring validation. > The criteria is "any application which draws an X window and runs from > within that window". If this app draws windows, run desktop-file-validate, > otherwise don't worry about it. For whatever it's worth, fedora-review is > what flagged this. If there is some path limits to be imposed on the check > that would be a good addition to fedora-review. > Yeah, this probably needs to be constrained to desktop files installed into /usr/share/applications, because a lot of things use .desktop and aren't desktop files in other parts of the file tree :/ > The only only thing is the extra license file, that didn't get fixed yet. > > -%license LICENSES/* > +%license LICENSES/GPL-2.0-or-later.txt Fixed, though ehh... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2156603 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
