https://bugzilla.redhat.com/show_bug.cgi?id=2156603 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Carl George 🤠 <carl@xxxxxxxxxx> --- This appears to be a C++ application. It must build require gcc-c++. https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_buildrequires_and_requires ================================================================================ `%license LICENSES/*` picks up two license files, GPL-2.0-or-later.txt and BSD-3-Clause.txt. Checking upstream the BSD-licensed file is a cmake file that isn't shipped in this package, so it should not be included. As far as I can tell the license field is correct, this is just about the license files that are included in the package. ================================================================================ This package installs a .desktop file. It must install it with desktop-file-install (in %install) or validate it with desktop-file-validate (in %check or %install). This also means adding a build requirement for desktop-file-utils. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files ================================================================================ /usr/share/config.kcfg and /usr/share/qlogging-categories5 are created by this package, but not owned by it. Those directories must be listed in %files, or this package must require another package that owns those directories (perhaps kf5-filesystem). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ ================================================================================ This package install a .metainfo.xml file. It must validate it with appstream-util (in %check or %install). This also means adding a build requirement for libappstream-glib. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2156603 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
