https://bugzilla.redhat.com/show_bug.cgi?id=2120119 --- Comment #28 from Neal Gompa <ngompa13@xxxxxxxxx> --- Issues: ======= > - Package installs a %{name}.desktop using desktop-file-install or desktop- > file-validate if there is such a file. I think this is not having desktop-file-validate and appstream-util validate in %check. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage > - systemd_post is invoked in %post, systemd_preun in %preun, and > systemd_postun in %postun for Systemd service files. > Note: Systemd service file(s) in waydroid > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/Scriptlets/#_scriptlets This is because "%systemd_post" is run in %posttrans rather than %post. I don't see a reason that this can't be moved to %post. > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name} = %{version}-%{release} in > waydroid-selinux This should be an easy fix. > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. Should be an easy fix. > waydroid.noarch: E: summary-too-long Container-based approach to boot a full Android system on a regular GNU/Linux system > waydroid.src: E: summary-too-long Container-based approach to boot a full Android system on a regular GNU/Linux system This needs to be shrunk to 79 columns. Once these are resolved, I can approve this. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2120119 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
