https://bugzilla.redhat.com/show_bug.cgi?id=2119494 --- Comment #94 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Looks good. Minor points: a) Still get warnings for undefined weak symbols: https://download.copr.fedorainfracloud.org/results/stansoft/aubit4gl/fedora-37-x86_64/05178189-aubit4gl/fedora-review/review.txt These are for the commands A4GL_add_pointer A4GL_assertion_full A4GL_can_pack_all A4GL_char_val A4GL_close_packer A4GL_clr_malloc_context A4GL_compile_time_convert A4GL_convlower A4GL_debug_full_extended_ln A4GL_delete_file A4GL_dumpstring A4GL_env_option_set A4GLEXDATA_initlib A4GL_exitwith A4GL_find_attrib_from_metric A4GL_find_pointer A4GL_find_pointer_val A4GL_get_as_c A4GL_get_ccnt A4GL_get_datatype_function_i A4GL_get_datatype_function_n A4GL_get_dtype A4GL_get_esql_ext A4GL_get_last_outfile A4GL_get_malloc_context A4GL_get_str_attribute A4GL_get_the_form_ptr A4GL_get_translated_id A4GL_global_A4GLSQL_get_sqlerrm A4GL_has_bool_attribute A4GL_has_datatype_function_i A4GL_has_pointer A4GL_has_str_attribute a4gl_htonl a4gl_htons A4GL_include_range_check A4GL_internal_build A4GL_internal_version a4gl_isalpha A4GL_is_just_int_literal A4GL_isno A4GL_is_number_datatype A4GL_is_numeric_datatype A4GL_isyes A4GL_key_val A4GL_make_downshift A4GL_memfile_fopen_buffer A4GL_memfile_fread A4GL_mja_fopen A4GL_module_has_function A4GL_new_append_ptr_list A4GL_new_expr_push_variable A4GL_new_expr_simple_string A4GL_new_list_get_count A4GL_new_literal_long_long A4GL_new_literal_string A4GL_new_prepend_ptr_list A4GL_new_ptr_list a4gl_ntohl a4gl_ntohs A4GL_null_as_null A4GL_open_file_dbpath A4GL_open_packer A4GL_output_common_header A4GL_pack_all A4GL_pack_remove_file A4GL_pause_execution A4GL_rationalize_list A4GL_read_data_from_file A4GL_read_fields A4GL_read_metrics A4GL_set_compile_time_convert A4GL_setenv A4GL_set_errm A4GL_set_fcompile_err A4GL_set_fld A4GL_set_last_outfile A4GL_set_malloc_context A4GL_sprintf A4GLSQLCV_check_requirement A4GLSQLCV_check_sql A4GLSQLCV_dtype_alias A4GLSQLCV_get_esql_datatype A4GLSQLPARSE_from_clause_collect_tables A4GL_strcat A4GL_strcpy A4GL_strendswith A4GL_strip_quotes A4GL_translate A4GL_trim A4GL_trim_nl A4GL_unpack_all A4GL_valid_common_header A4GL_warn A4GL_write_data_to_file a4gl_yyerror acl_getenv acl_getenv_not_set_as_0 acl_malloc2_With_Context acl_malloc_full acl_realloc_full append_cmd_int_list attributes_as_int clone_variable_usage downshift expand_parameters expr_as_string_when_possible find_variable_quick getDatatypeSig get_namespace get_select_list_item get_select_list_item_list has_cmd_int_list input_char input_double input_end_array input_end_struct input_end_union input_enum input_int input_long input_ptr_ok input_short input_start_array input_start_struct input_start_union input_string is_builtin_func make_select_stmt_v2 make_sql_string_and_free make_tab_and_col match_variable_usage new_cmd_int_list output_char output_double output_end_array output_end_struct output_end_union output_enum outputfilename output_int output_long output_nullptr output_okptr output_short output_start_array output_start_struct output_start_union output_string preprocess_sql_statement RP_xmlencode set_namespace set_yytext simple_expr_datatype upshift write_json_form yylineno Maybe linking needs to be updated as some of these libraries depend on others in aubit4gl b) In the spec file, above each patch can you add a short explanation for what the patch does? c) Timestamps for header files in the devel package are not preserved. However cp -p is used, so not sure what else can be done here d) libaubit4gl.so should link to libaubit4gl.so.1 not directly to libaubit4gl.so.1.5.3 e) Should a dependency on gcc or clang be explicitly added? 4glpc requires a C compiler, but with the current setup, a C compiler may not be installed when aubit4gl is installed. f) Why does the debuginfo package list internal private libraries as being provided? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119494 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
