Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: photoml - An XML DTD and tools for describing photographic metadata https://bugzilla.redhat.com/show_bug.cgi?id=419741 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-12-21 00:25 EST ------- The README says "GPL version 2" but the License: tag says GPLv2+. So is it "version 2 only", or "version 2 or later"? One thing I noticed during the build is the following: Cannot run XML merge tests without dtdto I assume this is part of the Perl XML::DTD package; did you plan on packaging that as well? Unfortunately this: %{_datadir}/doc/*/* doesn't actually include the directories under /usr/share/doc, just anything that's within them. The versioned documentation directory you get by using %doc is included for you automatically, but the unversioned one the package installs into isn't. You should use %{_datadir}/doc/%{name} instead, or convince the program to put the documentation in the versioned directory. * source files match upstream: 0de1f9a8b385725a572791e92ea6187377dc15be7111a3b587a2cd8cb2dcdf25 photoml-0.24.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (you can skip perl, but it's OK to have it) * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: photoml = 0.24-1.fc9 = /bin/sh /usr/bin/perl perl(Date::Manip) perl(File::Basename) perl(File::Copy) perl(File::Temp) perl(Getopt::Std) perl(Image::ExifTool) perl(strict) * %check is present and all tests pass: XSL defaults tests Failed 0 out of 33 tests Tool tests Failed 0 out of 4 tests X doesn't own /usr/share/doc/photoml * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review