[Bug 2120119] Review Request: waydroid - run android applications on wayland

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2120119



--- Comment #23 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> Waydroid uses Linux namespaces to run a full Android system in a container and provide Android applications on any GNU/Linux-based platform.
> The Android system inside the container has direct access to needed hardware through LXC and the binder interface.

Text needs to be wrapped at 79 columns.

> %{_systemd_util_dir}/system-preset/95-waydroid.preset

Presets are not allowed in any package except fedora-release. You'll need to
make a request for fedora-release to include it.

Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/#_how_to_enable_a_service_by_default

> if [ $1 -eq 1 ] && [ -x /usr/bin/systemctl ]; then
>   /usr/bin/systemctl start waydroid-container.service || :
> fi

This should also check if the service is enabled before attempting to start it.
Here's an example:
https://src.fedoraproject.org/rpms/snapd/blob/rawhide/f/snapd.spec#_877-885

> %triggerin -- %{name} < 1.2.1-13
> /usr/lib/systemd/systemd-update-helper mark-restart-system-units waydroid-container.service || :

What is this about? Also, this will probably never trigger since no package
entering Fedora predates this version.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2120119
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux