https://bugzilla.redhat.com/show_bug.cgi?id=2120119 --- Comment #17 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > %global debug_package %{nil} Why are we doing this? > Summary: waydroid This is not a valid summary > Patch0: setup-firealld.patch Typo? > Requires: (%{name}-selinux = %{version}-%{release} if selinux-policy-targeted) Shouldn't this be "selinux-policy-%{selinuxtype}"? > Requires: nftables iproute dnsmasq Please put these on their own lines > Recommends: python-pyclip This doesn't exist? > waydroid upgrade -o >/dev/null What happens when this fails? We can't have package transactions failing because of failed commands. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120119 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
