https://bugzilla.redhat.com/show_bug.cgi?id=1187030 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? Status|POST |ASSIGNED --- Comment #39 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Some fixes that were not caught earlier: Can you update the license field to: GPL-2.0-only see: https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ Can you remove the empty file? In the prep section add rm docs/documentation/api-ref.html $ rpmlint -e unused-direct-shlib-dependency unused-direct-shlib-dependency: The binary contains unused direct shared library dependencies. This may indicate gratuitously bloated linkage; check that the binary has been linked with the intended shared libraries only. Using $ ldd -u libgiza.so $ ldd -u libcpgplot.so Unused direct dependencies: /lib64/libX11.so.6 /lib64/libcairo.so.2 /lib64/libfontconfig.so.1 /lib64/libfreetype.so.6 $ ldd -u libpgplot.so Unused direct dependencies: /lib64/libX11.so.6 /lib64/libcairo.so.2 /lib64/libfontconfig.so.1 /lib64/libfreetype.so.6 It seems the makefile adds all libraries, and using -Wl,--as-needed seems not to help. https://unix.stackexchange.com/questions/473014/what-does-unused-direct-dependencies-mean Maybe further changes are needed in the setup? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1187030 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
