https://bugzilla.redhat.com/show_bug.cgi?id=2121585 --- Comment #40 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> --- Hey Benson! Me again. Just formating the past comment with proper quotes. Sorry for the mistake. > a) If you do a build in copr, you can get output of fedora-review, see: OK, I'll try to do this in order to get the review so I can figure out and fix the issues presented. > b) jquery is packaged: > https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/ > The spec file has both: > Requires: js-jquery > and > Provides: bundled(js-jquery) = 1.9.1 > Is this reasonable? Could only the packaged js-jquery be used? I think it is. The docs require this old version of jquery (1.9.1 vs 3.6.0 which is what Fedora packaged). Upstream has a ticket where they upgraded to the newest version that didn't break their demos and documentation. I'll propose to upgrade to v3.6.0 and, when they do, update the packages to use what Fedora provides. I'll remove the Requires js-jquery for now. Do you agree? > c) None of the other javascript libraries seem to be packaged. Are any of them likely to be used elsewhere? For example boostrap? In which case, could they be packaged separately? Well, they could be packaged but, for now, I'd like to go with what Petr Mensik suggested here: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/message/G4SR25UUCDF4EJCWUF5T5H4WENSUUO6B/ I'd like to do exactly that: * use the bundled js-query when possible (read above). * use bundled() for now and create bug tickets subsequently to create packages for those. The bootstrap one is a bit tricky. Janus' docs and demos use the ECMAScript part of bootstrap but not the CSS. The CSS is modified and is provided as a theme. That project is called Bootswatch: https://bootswatch.com/ In order to be consistent, I would have to package bootswatch and all the themes for Fedora. I am not saying no but I want to do this in a later occasion. IMHO, for now, we're good with the bundled() setup and, later on, I will submit packages for each and every one. Well, probably one exception; they use this node-js library from a different project. I would keep that one as bundled(). > d) $ rpmlint -e summary-too-long > summary-too-long: > The 'Summary:' must not exceed 80 characters. Right on. Will fix the summaries everywhere. > e) Demo and docs packages should probably be marked as noarch You're correct. I will mark them as so. > f) The cipher warning seems to come from line 491 in src/dtls.c see > https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/#_cc_applications > Probably an exemption or some coordination will be required with upstream. I will take this to upstream and see what they say. If that fails, I'll see what I can do with FESCo... if that's where one gets an exception granted. ;D > g) Maybe consider using this for The creative summit instead of Jitsi: > https://communityblog.fedoraproject.org/youre-invited-to-the-creative-freedom-summit-hosted-by-the-fedora-design-team/ > https://fedoraproject.org/wiki/Creative_Freedom_Summit_2023_Schedule > Would be happy to create a custom easily packaged theme. Err... sure. I wouldn't know where to start, hehe. I use janus as part of the communications stack that NextCloud's Talk requires. Let me know how can I help to do this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121585 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
