https://bugzilla.redhat.com/show_bug.cgi?id=2154218 --- Comment #6 from Timothée Floure <timothee.floure@xxxxxxxxxx> --- Yes, since these flags are set in %build by default. Ideally, I would like to propose a patch to upstream so that these flags are also evaluated at build time. I don't understand why you don't want to follow my recommendation, though. The configure stage belongs to the prep section for me - I want it there before I accept this review. My proposition is the following: Spec URL: https://paste.sr.ht/blob/a93621d391ed73a7043e7a48f51edf89d69ea9d3 SPRM URL: https://kojipkgs.fedoraproject.org//work/tasks/4049/95614049/harec-0%5E20221126gita1aa5039-4.fc38.src.rpm Do you have anything against it? Sorry for the nitpicking. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2154218 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
