https://bugzilla.redhat.com/show_bug.cgi?id=2119494 --- Comment #84 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF Unlimited License (with License Retention)", "FSF Unlimited License [generated file]", "GNU General Public License, Version 2", "SSLeay", "*No copyright* GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]", "MIT License", "GNU Lesser General Public License, Version 2.1", "GNU General Public License v2.0 or later", "GNU Library General Public License v2 or later [obsolete FSF postal address (Temple Place)]", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* [generated file]", "GNU General Public License", "GNU General Public License v3.0 or later", "X11 License [generated file]", "BSD 3-Clause License", "Public domain", "*No copyright* GNU General Public License", "*No copyright* Public domain", "FSF Unlimited License", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "GNU Library General Public License v2 or later [obsolete FSF postal address (Mass Ave)]", "Public domain MIT License", "MIT License BSD 3-Clause License", "NTP License", "[generated file]", "LGPL (v2.1 or v3.0)", "GNU General Public License, Version 2 [obsolete FSF postal address (Mass Ave)]", "MIT (old)", "GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)]". 2301 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/2119494-aubit4gl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/aubit4gl/plugins-1.5_3, /usr/lib64/aubit4gl/etc, /usr/lib64/aubit4gl/tools, /usr/include/aubit4gl/dataio [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/aubit4gl/plugins-1.5_3, /usr/include/aubit4gl/dataio, /usr/lib64/aubit4gl/etc, /usr/lib64/aubit4gl/tools [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 16 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: aubit4gl-1.5_3^20221019.r12787-1.fc38.aarch64.rpm aubit4gl-devel-1.5_3^20221019.r12787-1.fc38.aarch64.rpm aubit4gl-debuginfo-1.5_3^20221019.r12787-1.fc38.aarch64.rpm aubit4gl-debugsource-1.5_3^20221019.r12787-1.fc38.aarch64.rpm aubit4gl-1.5_3^20221019.r12787-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgqlj0qv9')] checks: 31, packages: 5 aubit4gl.spec:30: W: unversioned-explicit-provides lib%{name}.so()(64bit) aubit4gl-devel.aarch64: W: no-documentation aubit4gl.aarch64: E: incorrect-fsf-address /usr/lib64/aubit4gl/etc/config/missing aubit4gl.aarch64: E: incorrect-fsf-address /usr/share/licenses/aubit4gl/COPYING aubit4gl-debugsource.aarch64: E: files-duplicated-waste 103004 aubit4gl.aarch64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/aubit4gl/plugins-1.5_3/libUI_XML.so 5 packages and 0 specfiles checked; 3 errors, 3 warnings, 3 badness; has taken 12.8 s Rpmlint (debuginfo) ------------------- Checking: aubit4gl-debuginfo-1.5_3^20221019.r12787-1.fc38.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0hg6j32v')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 6.0 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 Unversioned so-files -------------------- aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libA4GL_HTML.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libA4GL_file.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libA4GL_memcache.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libA4GL_pick.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libA4GL_roman.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libA4GL_string.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libDATA_module.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libDATA_module_definition.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libDATA_report.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libDATA_struct_form.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libEXREPORT_NOPDF.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libFORM_GENERIC.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libFORM_NOFORM.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libHELP_std.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libLEX_C.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libLEX_CS.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libLEX_EC.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libLEX_WRITE.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libLOGREPPROC_CSV.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libLOGREPPROC_HTML.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libLOGREPPROC_TXT.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libMSG_NATIVE.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libPACKER_FORMXML.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libPACKER_MEMPACKED.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libPACKER_PACKED.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libPACKER_PERL.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libPACKER_XML.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libRPC_NORPC.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libSQLPARSE_INFORMIX.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libSQLPARSE_NONE.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libSQL_FILESCHEMA.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libSQL_nosql.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libSQL_pg.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libSQL_pg8.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libUI_CONSOLE.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libUI_HL_TUI.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libUI_HL_TUIN.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libUI_TUI.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libUI_TUI_wide.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libUI_XML.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libbarcode.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/libchannel.so aubit4gl: /usr/lib64/aubit4gl/plugins-1.5_3/liberrhook_sample.so aubit4gl: /usr/lib64/libaubit4gl-1.5_3.so Source checksums ---------------- https://downloads.sourceforge.net/project/aubit4gl/Aubit4gl-manual/aubitmanpages.tar.bz2 : CHECKSUM(SHA256) this package : 7eb7606b396807a31c3841892289b672530ec74b54b9032c46728885ef84b537 CHECKSUM(SHA256) upstream package : 7eb7606b396807a31c3841892289b672530ec74b54b9032c46728885ef84b537 https://downloads.sourceforge.net/project/aubit4gl/Snapshots/aubit4gl-r12787.tar.bz2 : CHECKSUM(SHA256) this package : 0beff4af9e49bebfdd1f4253685d616a945ae2deef408d89e33c84a394082259 CHECKSUM(SHA256) upstream package : 0beff4af9e49bebfdd1f4253685d616a945ae2deef408d89e33c84a394082259 Requires -------- aubit4gl (rpmlib, GLIBC filtered): /usr/bin/sh config(aubit4gl) ld-linux-aarch64.so.1()(64bit) libaubit4gl-1.5_3.so()(64bit) libc.so.6()(64bit) libform.so.6()(64bit) libformw.so.6()(64bit) libm.so.6()(64bit) libncurses.so.6()(64bit) libncursesw.so.6()(64bit) libpanel.so.6()(64bit) libpanelw.so.6()(64bit) libpq.so.5()(64bit) libpq.so.5(RHPG_9.6)(64bit) libtinfo.so.6()(64bit) rtld(GNU_HASH) aubit4gl-devel (rpmlib, GLIBC filtered): aubit4gl(aarch-64) aubit4gl-debuginfo (rpmlib, GLIBC filtered): aubit4gl-debugsource (rpmlib, GLIBC filtered): Provides -------- aubit4gl: aubit4gl aubit4gl(aarch-64) config(aubit4gl) libaubit4gl-1.5_3.so()(64bit) libaubit4gl.so()(64bit) aubit4gl-devel: aubit4gl-devel aubit4gl-devel(aarch-64) aubit4gl-debuginfo: aubit4gl-debuginfo aubit4gl-debuginfo(aarch-64) debuginfo(build-id) libA4GL_HTML.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libA4GL_file.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libA4GL_memcache.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libA4GL_pick.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libA4GL_roman.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libA4GL_string.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libDATA_module.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libDATA_module_definition.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libDATA_report.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libDATA_struct_form.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libEXREPORT_NOPDF.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libFORM_GENERIC.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libFORM_NOFORM.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libHELP_std.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libLEX_C.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libLEX_EC.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libLEX_WRITE.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libLOGREPPROC_CSV.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libLOGREPPROC_HTML.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libLOGREPPROC_TXT.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libMSG_NATIVE.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libPACKER_FORMXML.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libPACKER_MEMPACKED.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libPACKER_PACKED.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libPACKER_PERL.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libPACKER_XML.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libRPC_NORPC.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libSQLPARSE_INFORMIX.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libSQLPARSE_NONE.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libSQL_FILESCHEMA.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libSQL_nosql.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libSQL_pg.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libSQL_pg8.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libUI_CONSOLE.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libUI_HL_TUI.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libUI_HL_TUIN.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libUI_TUI.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libUI_TUI_wide.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libUI_XML.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libaubit4gl-1.5_3.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libbarcode.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) libchannel.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) liberrhook_sample.so-1.5_3^20221019.r12787-1.fc38.aarch64.debug()(64bit) aubit4gl-debugsource: aubit4gl-debugsource aubit4gl-debugsource(aarch-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2119494 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Ocaml, Python, PHP, Java, fonts, Haskell, R, Perl, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Unversioned .so files seem not to be provided, so this is ok. b) May want to add %dir /usr/lib64/aubit4gl %dir /usr/lib64/aubit4gl/plugins-1.5_3 %dir /usr/lib64/aubit4gl/etc %dir /usr/lib64/aubit4gl/tools %dir /usr/include/aubit4gl %dir /usr/include/aubit4gl/dataio to the spec file c) libaubit4gl-1.5_3.so should be in the devel package and should be versioned. The soname was being used before. Can it be added again? d) Can probably remove Provides: lib%{name}.so()(64bit) from the spec file. e) Use spdx identifiers for the licenses: https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2119494 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
