[Bug 2126785] Review Request: usbrelay - USB-connected electrical relay control, based on hidapi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2126785

Darryl Bond <darryl.bond@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(bjorn@xn--rombobj
                   |                            |rn-67a.se)
                   |                            |needinfo?(bjorn@xn--rombobj
                   |                            |rn-67a.se)



--- Comment #21 from Darryl Bond <darryl.bond@xxxxxxxxx> ---
@bjorn@xxxxxxxxxxxxxxxxxxxx 

Fixed:
25: After some reading, I realise what the issue was (%{_isa}, now fixed
30: systemd_postun_with_restart returned. Tested.
27: Added the %generate_buildrequires macro and moved pyproject_buildrequires
there and tested.
28: Comment added
31: RPMLint no longer complains about the length of the summary and mixing of
tabs and spaces

Not fixed but not blocking:
21: Package signing is not yet used, once used I will release a future version
with signed packages
29: Manual starting of the daemon still fails without the hardware. I can find
nothing in systemd that will prevent the daemon attempting to run if the USB
device isn't present. 
I did find the recommendation of using udev, which is being used as
recommended.
The correct fix is to fix the daemon so it keeps running without the hardware
and probe for it periodically.

Please find the latest version of the spec file here:
https://github.com/darrylb123/usbrelay/blob/master/rpm/usbrelay.spec


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2126785
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux