Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: mktemp https://bugzilla.redhat.com/show_bug.cgi?id=226147 ville.skytta@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ville.skytta@xxxxxx Status|NEW |ASSIGNED ------- Additional Comments From ville.skytta@xxxxxx 2007-12-20 14:51 EST ------- Only some minor issues: Could use "make %{?_smp_mflags}"; not much of a deal for something this small. "make install" should use %{_mandir} instead of hardcoding /usr/share/man. mktemp-1.5-nostrip.patch can be 'cvs rm'd. Include README and RELEASE_NOTES in %doc? License should probably be "BSD with advertising", see priv_mktemp.c boilerplate. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review