https://bugzilla.redhat.com/show_bug.cgi?id=2025124 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |carl@xxxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |carl@xxxxxxxxxx --- Comment #14 from Carl George 🤠 <carl@xxxxxxxxxx> --- I can take this review. ================================================================================ Do you think you can update this spec file to use the current Python packaging guidelines? At a glance it looks mostly correct for the legacy guidelines (which are still allowed), but since we're re-reviewing it now is a great time to convert it. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ ================================================================================ The license field needs to be updated to use an SPDX license expression. -License: MIT and GPLv3+ +License: MIT AND GPL-3.0-or-later It also appears that the license breakdown comment is out of date. licensecheck found libqtile/widget/cmus.py and libqtile/widget/moc.py as the only files under the GPL. https://docs.fedoraproject.org/en-US/legal/license-field/ ================================================================================ Upstream has a test suite, try to run it in %check if possible. The upstream tox file looks like it tries to pip install stuff, which won't work in the build environment. You might choose to patch this file and run the tests with %tox. Alternatively you could run the tests directly with %pytest. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests ================================================================================ For the %setup macros, the default directory name is %{name}-%{version}, so that flag can be left out. -%setup -q -n qtile-%{version} +%setup -q Optionally you could switch this to %autosetup, which will automatically apply patches, if and when they are needed. -%setup -q -n qtile-%{version} +%autosetup -p 1 https://docs.fedoraproject.org/en-US/packaging-guidelines/#_autosetup -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2025124 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
