https://bugzilla.redhat.com/show_bug.cgi?id=2119494 --- Comment #61 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Upstream does not use the standard file system hierarchy: https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard The configure script also needs an update, and there are many build warnings - some of these problems might be caught if a continuous integration tool is integrated into the build workflow, but this changes may take time if upstream is open to them all. Regarding contents of /usr/lib64/aubit4gl/etc/* other than /usr/lib64/aubit4gl/etc/convertsql, might any of the other files be useful for other applications that use aubit4gl? %{_libdir}/%{name}/etc/convertsql/ is listed as a directory, need to list files that should be available, pattern matching can be used, but type of content should be made clear. /etc/ld.so.conf.d/%{name}-%{_arch}.conf maybe problematic since it may add private application only plugin libraries The suggestion from https://fedoraproject.org/wiki/Common_Rpmlint_issues#invalid-soname is to use rpath: https://fedoraproject.org/wiki/RPath_Packaging_Draft#Rpath_for_Internal_Libraries fedora-review output is also available: https://download.copr.fedorainfracloud.org/results/stansoft/aubit4gl/fedora-37-x86_64/05130543-aubit4gl/fedora-review/review.txt https://download.copr.fedorainfracloud.org/results/stansoft/aubit4gl/fedora-37-x86_64/05131361-aubit4gl/fedora-review/review.txt The build 05130543 has fewer errors, in particular: aubit4gl.x86_64: E: script-without-shebang /usr/bin/aubit aubit4gl.x86_64: E: script-without-shebang /usr/bin/report.pm aubit4gl.x86_64: E: script-without-shebang /usr/bin/using.pm Please make a docs subpackage to address - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1013760 bytes in 18 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation Should permissions be change to remove the warning: aubit4gl.x86_64: W: non-executable-in-bin /usr/bin/aubit 644 Can -fPIC flag be added to remove the warnings: aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/4glc aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/4glpc aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/a4gl.4ae aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/aace aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/aace_perl aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/adbschema aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/adecompile aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/afinderr aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/amkmessage aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/asql_g.4ae aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/aubit-config aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/configurator aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/convertsql aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/default_frm aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/fcompile aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/fdecompile aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/fglproto aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/fshow aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/generate_aace aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/ide1.4ae aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/loadmap aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/mcompile aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/mdecompile aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/quickguide.4ae aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/sql_parse aubit4gl.x86_64: W: position-independent-executable-suggested /usr/bin/unmkmessage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2119494 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
