[Bug 2150517] Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2150517

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
                 CC|                            |decathorpe@xxxxxxxxx
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Looks good to me, with one possible exception:

> ## Credits
> 
> The SVG fixtures used for testing are provided by
> 
> * [Openclipart](https://en.wikipedia.org/wiki/Openclipart)
> * [SVG Specification Examples](https://www.w3.org/TR/SVG2/)
> * [W3C SVG Working Group](https://www.w3.org/Graphics/SVG/)
> 
> under their respective licenses.

This applies to the files under the "/fixtures" directory.

Openclipart: CC0-1.0, is OK for content.

SVG Specification examples:
Seems to be covered by this license:
https://www.w3.org/Consortium/Legal/2015/doc-license
Not sure if it's OK for content in Fedora.

W3C SVG Working Group: No idea where examples came from or what license applies
to them.

It might be easiest to just nuke the "fixtures" directory and use a "clean"
source tarball ...
Not sure why / how this wasn't caught during the last package review (but it
seems to have been a bit ... rushed:
https://bugzilla.redhat.com/show_bug.cgi?id=1910871)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2150517
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux