https://bugzilla.redhat.com/show_bug.cgi?id=2152347 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thanks for the review, Benson. You're fast! I hadn't even finished writing up an email to fedora-devel-list about this review. :-) (In reply to Benson Muite from comment #1) > fonts: > [!]: Run repo-font-audit on all fonts in package. > Note: Cannot find repo-font-audit, install fontpackages-tools package > to make a comprehensive font review. > See: url: undefined > [!]: Run ttname on all fonts in package. > Note: Cannot find ttname command, install ttname package to make a > comprehensive font review. > See: url: undefined Wow, fedora-review is really out of date for fonts. I see this has already been reported in bug 1996210. > a) Why use OFL-1.1-RFN rather than OFL-1.1 ? Several of the fonts are listed as having Reserved Font Names (RFN) in OFL.txt, which is listed as Source1. The Lyrics font is the only one not listed there, so it is the only subpackage with license of plain OFL-1.1 instead of OFL-1.1-RFN. > b) Using fc-scan on the Finale Ash font file, foundry is listed as foundry: > "SMTG"(s) not MakeMusic. Should this be updated? Hmmm. This is what I get (in part) from "otfinfo -i" on the font files. FinaleAsh.otf: Manufacturer: MakeMusic Trademark: Finale Ash is a trademark of MakeMusic. Copyright: Copyright (c) 2021 by MakeMusic. All rights reserved. Vendor ID: SMTG FinaleAshText.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Ash Text is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: MACR FinaleBroadway.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Broadway is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleBroadwayLegacyText.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Broadway Legacy Text is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: pyrs FinaleBroadwayText.otf: Manufacturer: Mark F. Adler Trademark: Finale Broadway Text is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: PfEd FinaleEngraver.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Engraver is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleJazz.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Jazz is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2022 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleJazzText.otf: Manufacturer: Richard Sigler Trademark: Finale Jazz Text is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: MACR FinaleJazzTextLowercase.otf: Manufacturer: Richard Sigler Trademark: Finale Jazz Text Lowercase is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2022 by MakeMusic, Inc. All rights reserved. Vendor ID: MACR FinaleLegacy.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Legacy is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleLyrics-Bold.otf: Manufacturer: Mark F. Adler Trademark: Finale Lyrics Bold is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved. Vendor ID: pyrs FinaleLyrics-Italic.otf: Manufacturer: Mark F. Adler Trademark: Finale Lyrics Italic is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved. Vendor ID: pyrs FinaleLyrics-Regular.otf: Manufacturer: Mark F. Adler Trademark: Finale Lyrics is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic Inc.. All rights reserved. Vendor ID: pyrs FinaleMaestro.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Maestro is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: SMTG FinaleMaestroText-Bold.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Maestro Text Bold is a trademark of MakeMusic, Inc.. Copyright: Copyright (c) 2021 by MakeMusic, Inc.. All rights reserved. Vendor ID: pyrs FinaleMaestroText-BoldItalic.otf: Manufacturer: MakeMusic, Inc. Trademark: Finale Maestro Text Bold Italic is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: pyrs FinaleMaestroText-Italic.otf: Manufacturer: MakeMusic, Inc Trademark: Finale Maestro Text Italic is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: pyrs FinaleMaestroText-Regular.otf: Manufacturer: MakeMusic, Inc Trademark: Finale Maestro Text is a trademark of MakeMusic, Inc. Copyright: Copyright (c) 2021 by MakeMusic, Inc. All rights reserved. Vendor ID: pyrs It looks like fc-scan interprets the Vendor ID as the foundry, but that doesn't look right. Those look like some kind of internal code; they are all 4 letters for one thing. Also, they aren't consistent, and none of them have any obvious connection with MakeMusic. Given the trademark and copyright marks, I *think* MakeMusic is the correct foundry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2152347 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
