https://bugzilla.redhat.com/show_bug.cgi?id=2124697 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(decathorpe@gmail. | |com) | --- Comment #66 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Hi! Sorry for the radio silence. I didn't remember that I had assigned this bug to myself ... I don't really have much time to spend on Fedora these days, so I cannot promise a formal review of this package. If somebody else wants to take a stab at it before I can come back to this, feel free to un-assign me from this bug and take over. For what it's worth, I think the Rust related things in this package look good now, with one exception: The way cargo is invoked in src/cargo-build.sh is not compatible with Fedora packaging guidelines, as it makes cargo ignore the default compiler flags in Fedora, which is explicitly forbidden. So if at all possible, the cargo-build.sh script should probably not be used during the build, but it should be possible to replicate the only two lines in it that matter, i.e. """ ( set -x && RUSTFLAGS="${rustflags[*]}" cargo build "${args[@]}" --color always \ --locked ) cp "src/target/${profile}/libblkio.so" "src/libblkio.so.${version}" """ with calls to the %cargo_build macro (making the sed "s/--locked/--offline/g" also unnecessary) and the cp call in %build. Not sure how that change could be integrated in meson, though - but does it even need to be? I.e. would it be possible to make %build something like """ %build %meson %cargo_build cp "src/target/${profile}/libblkio.so" "src/libblkio.so.${version}" %meson_build """ And patch meson.build to not run cargo-build.sh at all? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2124697 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
