[Bug 2144864] Review Request: safeint - Class library for C++ that manages integer overflows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2144864



--- Comment #5 from Alejandro Alvarez <a.alvarezayllon@xxxxxxxxx> ---
Mmmm, unfortunately the tests fail with an abort on i686.

I have spent a bit debugging, and it seems the compilation flag -ftrapv set by
Fedora
steps on SafeInt handling of overflows.

With that flag, gcc calls __mulvdi3 when using __builtin_smulll_overflow, which
aborts the execution on overflow.
SafeInt expects a boolean flagging the overflow [1].

I would override the build flags and drop this one on i686 [2], justifying why.


[1]
https://github.com/dcleblanc/SafeInt/blob/92b8e813ab944c767f4b30b80d3eeb79e3b0c999/SafeInt.hpp#L1770
[2] https://fedoraproject.org/wiki/User:Tibbs/SensitiveSpecs#Compiler_flags


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2144864
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux