https://bugzilla.redhat.com/show_bug.cgi?id=2148595 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |lkundrak@xxxxx CC| |lkundrak@xxxxx Flags| |fedora-review+ --- Comment #3 from Lubomir Rintel <lkundrak@xxxxx> --- * Package named properly * Packaging the latest version * Source matches upstream * License tag correct * License packaged, good for Fedora * Filelist sane * Provides sane * Requires sane * rpmlint happy * SPEC file clean and legible * Builds fine in mock * Macros used consistently The package is APPROVED One minor nit: 0.) Please don't repeate the package name in %description: -linetable is a library parse and generate co_linetable attributes -in Python code objects. Something like this (the same as upstream uses on their website) would be more reasonable: +Library to parse and generate co_linetable attributes in Python code +objects. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2148595 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
