https://bugzilla.redhat.com/show_bug.cgi?id=2151236 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Yes. In this case, I think removing the tests/ directory would be fine, since the files are not referenced explicitly in Cargo.toml (i.e. the tests there are only found by cargo autodiscovery in the usual "tests" directory). But in general, just removing broken shebangs or stray executable bits should be safer, and not break builds of the crate. Or, in this case, you could just remove the "gen_test_cases.py" script (assuming it's the file with the unwanted shebang), since it's neither executed during tests, nor needed for building the crate - i.e. add `rm tests/gen_test_cases.py` between %autosetup and %cargo_prep. Doing it in %prep also ensures that if removing the file has any negative effects, they also happen during the package's build, and not only in subsequent builds of this crate as dependency of another package. Other than that, the package looks good to me, and I'll approve it once that's sorted out. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2151236 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
