[Bug 2151236] Review Request: rust-pep440 - Parse and compare Python PEP440 style version numbers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2151236

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx
              Flags|                            |fedora-review?
                 CC|                            |decathorpe@xxxxxxxxx



--- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> # Do not ship tests
> rm -r %{buildroot}/%{crate_instdir}/tests

Where did you get this from? In general, this is not necessary, and in some
cases, doing this might even break builds of this crate as dependency of other
packages. Since tests are usually just a few 100s to 1000s of bytes, we don't
bother dealing with the potential for breaking things by removing the files.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2151236
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux