[Bug 2142671] Review Request: lua-cosmo - Safe templates for Lua

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2142671



--- Comment #4 from Jonny Heggheim <hegjon@xxxxxxxxx> ---
Updated the spec+srpm with same URL:

Spec URL: https://jonny.fedorapeople.org/lua-cosmo.spec
SRPM URL: https://jonny.fedorapeople.org/lua-cosmo-16.06.04-1.fc36.src.rpm

I was not sure how to include the %license, I probably started on including a
separate license file and probably found out later that it was inlined in the
documentation.

 * Changed lua-lpeg to unversioned.
 * Removed the extra %license
 * Tidy the %docs 

The cosmo.md file is included twice, I am not sure how the %doc macro works, it
should be possible to symlink instead to save 18KB.

Looks like this now:
$ rpm -qlv lua-cosmo
drwxr-xr-x    2 root     root                        0 Dec  5 21:50
/usr/share/doc/lua-cosmo
-rw-r--r--    1 root     root                      923 Jun  4  2016
/usr/share/doc/lua-cosmo/README
-rw-r--r--    1 root     root                    18337 Jun  4  2016
/usr/share/doc/lua-cosmo/cosmo.md
-rw-r--r--    1 root     root                     1824 Jun  4  2016
/usr/share/doc/lua-cosmo/sample.lua
drwxr-xr-x    2 root     root                        0 Dec  5 21:50
/usr/share/licenses/lua-cosmo
-rw-r--r--    1 root     root                    18337 Jun  4  2016
/usr/share/licenses/lua-cosmo/cosmo.md
drwxr-xr-x    2 root     root                        0 Dec  5 21:50
/usr/share/lua/5.4/cosmo
-rw-r--r--    1 root     root                    10172 Dec  5 21:50
/usr/share/lua/5.4/cosmo.lua
-rw-r--r--    1 root     root                     4337 Dec  5 21:50
/usr/share/lua/5.4/cosmo/fill.lua
-rw-r--r--    1 root     root                     5049 Dec  5 21:50
/usr/share/lua/5.4/cosmo/grammar.lua


$ ls -lah /usr/share/licenses/lua-cosmo/cosmo.md
/usr/share/doc/lua-cosmo/cosmo.md
.rw-r--r--. root root 18 KB Sat Jun  4 20:59:21 2016 
/usr/share/licenses/lua-cosmo/cosmo.md
.rw-r--r--. root root 18 KB Sat Jun  4 20:59:21 2016 
/usr/share/doc/lua-cosmo/cosmo.md


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2142671
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux