[Bug 2150506] Review Request: python-pypresence - Discord Rich Presence Client in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2150506



--- Comment #5 from Steve Cossette <farchord@xxxxxxxxx> ---
(In reply to Miro Hrončok from comment #4)
> The source URL returns 404:
> 
> $ spectool -g -R python-pypresence.spec 
> Downloading:
> https://github.com/qwertyqwerty/pypresence/archive/refs/tags/4.2.1.tar.gz
> Download failed:
> 404 Client Error: Not Found for url:
> https://github.com/qwertyqwerty/pypresence/archive/refs/tags/4.2.1.tar.gz
> -   0.0 B Elapsed Time: 0:00:00  
> 
> Actually, the entire https://github.com/qwertyqwerty/pypresence returns 404.
> I belive it is supposed to be https://github.com/qwertyquerty/pypresence

Right, that was a typo, which I fixed now:

❯ spectool -g -R python-pypresence.spec
Downloading:
https://github.com/qwertyquerty/pypresence/archive/refs/tags/4.2.1.tar.gz
| 367.1 KiB Elapsed Time: 0:00:00                                               
Downloaded: 4.2.1.tar.gz


> 
> 
> 
> BuildArch:	noarch
> 
> This mixes tabs and spaces in the spec file. Could you please stick to one?
Done. Replaced the tabs by spaces.
> 
> 
> There are no tests in %check. Could you please at least try to import the
> Python module to see if it is importable?
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #py3_check_import

Done. mockbuild did the test and it worked.

Thanks again for your help!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2150506
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux