[Bug 2150506] Review Request: python-pypresence - Discord Rich Presence Client in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2150506

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mhroncok@xxxxxxxxxx
             Blocks|                            |2116001



--- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Could you please use links for the spec and the SRPM that allow direct download
by automation? Thanks.

Spec sanity:


> %global debug_package %{nil}

This usually indicates the package should be noarch (BuildArch: noarch)
instead. Since this is a pure python package, this is also the case here.


> License:        BSD-3

This is not a valid SPDX license identifier. Did you mean BSD-3-Clause?
https://docs.fedoraproject.org/en-US/legal/allowed-licenses/


> #%package -n python3-pypresence

This should remain here, the main package (SRPM) should be named
python-pypresence and there should be a subpackage named python3-pypresence.


> %{?python_provide:%python_provide python3-pypresence}

This is deprecated and not needed. Please remove it.



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2116001
[Bug 2116001] lutris-0.5.12 is available
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2150506
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux