https://bugzilla.redhat.com/show_bug.cgi?id=1991145 --- Comment #9 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello Jakub! I have fixed the issues. Please check the following files. Spec URL: https://hiwkby.fedorapeople.org/python-oslo-service.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-service-3.0.0-6.fc38.src.rpm Koji(success): https://koji.fedoraproject.org/koji/taskinfo?taskID=94867239 > There is a nice paragraph explaining the package in the project > README - https://opendev.org/openstack/oslo.service > Can we use that as a description? Fixed. I use the sentences from the README.rst file. https://opendev.org/openstack/oslo.service/src/branch/master/README.rst > Does this fail only for CentOS7? > > In such case, we can conditionally run the tests for the rest of the > distributions, e.g. Fixed. I uncomment the lines because I firstly want to push this package for Rawhide branch. I also introduce the new patch for tests and use tox for the tests. > The email address should be in < and > brackets, as you did for your > previous changelog records Fixed. Sorry for my typos. m(_ _)m ``` *** /home/fedora/hiwkby/public_html/python-oslo-service.spec 2022-11-16 03:46:59.626630713 +0000 --- python-oslo-service.spec 2022-12-03 06:41:11.128314842 +0000 *************** *** 6,16 **** %global with_doc 1 %global common_desc \ ! Library for running OpenStack services Name: python-%{pkg_name} Version: 3.0.0 ! Release: 5%{?dist} Summary: Oslo service library License: ASL 2.0 --- 6,17 ---- %global with_doc 1 %global common_desc \ ! oslo.service provides a framework for defining new long-running services \ ! using the patterns established by other OpenStack applications. Name: python-%{pkg_name} Version: 3.0.0 ! Release: 6%{?dist} Summary: Oslo service library License: ASL 2.0 *************** *** 21,26 **** --- 22,30 ---- Source101: https://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz.asc Source102: https://releases.openstack.org/_static/%{sources_gpg_sign}.txt %endif + # This patch is temporary until upstream releases 3.0.1. See + # https://bugs.launchpad.net/oslo.service/+bug/1988308 + Patch1: test_loopingcall.py.patch BuildArch: noarch # Required for tarball sources verification *************** *** 54,59 **** --- 58,64 ---- BuildRequires: python3-webob BuildRequires: python3-paste BuildRequires: python3-paste-deploy + BuildRequires: python3-tox Requires: python3-eventlet >= 0.25.2 Requires: python3-greenlet *************** *** 107,113 **** %if 0%{?sources_gpg} == 1 %{gpgverify} --keyring=%{SOURCE102} --signature=%{SOURCE101} --data=%{SOURCE0} %endif ! %autosetup -n %{pypi_name}-%{upstream_version} -S git %build %{py3_build} --- 112,118 ---- %if 0%{?sources_gpg} == 1 %{gpgverify} --keyring=%{SOURCE102} --signature=%{SOURCE101} --data=%{SOURCE0} %endif ! %autosetup -p0 -n %{pypi_name}-%{upstream_version} -S git %build %{py3_build} *************** *** 127,134 **** %check # FIXME: https://review.openstack.org/279011 seems to break tests in CentOS7, # creating an infinite loop ! #python3 setup.py test || ! #rm -rf .testrepository %files -n python3-%{pkg_name} %doc README.rst --- 132,139 ---- %check # FIXME: https://review.openstack.org/279011 seems to break tests in CentOS7, # creating an infinite loop ! tox -e py3|| ! rm -rf .testrepository %files -n python3-%{pkg_name} %doc README.rst *************** *** 147,162 **** %endif %changelog ! * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@xxxxxxxxx - 3.0.0-5 - Fixes issues on the packaging guidelines ! * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@xxxxxxxxx - 3.0.0-4 - Fixes issues on the packaging guidelines ! * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@xxxxxxxxx - 3.0.0-3 - Fixes issues on the packaging guidelines ! * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@xxxxxxxxx - 3.0.0-2 - Fixes issues on the packaging guidelines * Wed Oct 26 2022 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 3.0.0-1 --- 152,171 ---- %endif %changelog ! * Sat Dec 03 2022 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 3.0.0-6 ! - Applies a patch for tests and uses tox for tests - Fixes issues on the packaging guidelines ! * Wed Nov 16 2022 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 3.0.0-5 - Fixes issues on the packaging guidelines ! * Wed Nov 09 2022 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 3.0.0-4 - Fixes issues on the packaging guidelines ! * Tue Nov 08 2022 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 3.0.0-3 ! - Fixes issues on the packaging guidelines ! ! * Tue Nov 01 2022 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 3.0.0-2 - Fixes issues on the packaging guidelines * Wed Oct 26 2022 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 3.0.0-1 ``` Thanks in advance, Hirotaka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1991145 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
