[Bug 2133789] Review Request: media-downloader - GUI frontend to multiple CLI based downloading programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2133789



--- Comment #3 from MartinKG <mgansser@xxxxxxxxxxxxxx> ---
(In reply to Jakub Kadlčík from comment #2)
> Hello Martin,
> thank you for the package.
> 
> 
> > Name:           media-downloader
> 
> Nitpicking but there is an unnecessary blank line above the first line
> 
> 
> > License:        GPLv2
> 
> The old Fedora license identifiers are not allowed for new packages
> anymore (according to SPDX Licenses Phase 1):
> https://fedoraproject.org/wiki/Changes/
> SPDX_Licenses_Phase_1#Can_new_packages_use_the_older_Fedora_license_abbreviat
> ions?
> 
> Otherwise LGTM

Hi Jakub,

thanks for reviewing the package.
I have changed the 2 mentioned issues.

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/media-downloader.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/media-downloader-2.7.0-2.fc37.src.rpm

%changelog
* Fri Dec 02 2022 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 2.7.0-2
- Remove unnecessary blank line above the first line
- Use new SPDX license format


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2133789
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux