https://bugzilla.redhat.com/show_bug.cgi?id=2142712 Iñaki Ucar <i.ucar86@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #2 from Iñaki Ucar <i.ucar86@xxxxxxxxx> --- All good, just the usual false positives for R packages from the review tool. Unretirement APPROVED. I leave the output from the tool below for reference. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/R-V8 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* MIT License", "Unknown or generated", "MIT License". 53 files have unknown license. Detailed output of licensecheck in /home/iucar/fedora- review/2142712-R-V8/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 4.2.2, packaged version is 4.2.2 ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 R-V8.x86_64: W: package-with-huge-docs 90% R-V8.x86_64: W: files-duplicate /usr/lib64/R/library/V8/help/v8.html /usr/lib64/R/library/V8/help/V8.html:/usr/lib64/R/library/V8/help/engine_info.html:/usr/lib64/R/library/V8/help/new_context.html R-V8.x86_64: W: files-duplicate /usr/lib64/R/library/V8/help/wasm_features.html /usr/lib64/R/library/V8/help/wasm.html R-V8.x86_64: W: dangling-symlink /usr/lib64/R/library/V8/js/underscore.js /usr/share/javascript/underscore/underscore-min.js 3 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.4 s Unversioned so-files -------------------- R-V8: /usr/lib64/R/library/V8/libs/V8.so Source checksums ---------------- https://cran.r-project.org/src/contrib/V8_4.2.2.tar.gz : CHECKSUM(SHA256) this package : 50653527198637a37c010052f394839f50a3c643975aac1d04e42d36f8e5313b CHECKSUM(SHA256) upstream package : 50653527198637a37c010052f394839f50a3c643975aac1d04e42d36f8e5313b Requires -------- R-V8 (rpmlib, GLIBC filtered): R(ABI) R(Rcpp) R(curl) R(jsonlite) R(utils) R-core js-underscore libR.so()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libnode.so.108()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) R-V8-debuginfo (rpmlib, GLIBC filtered): R-V8-debugsource (rpmlib, GLIBC filtered): Provides -------- R-V8: R(V8) R-V8 R-V8(x86-64) bundled(js-crossfilter) R-V8-debuginfo: R-V8-debuginfo R-V8-debuginfo(x86-64) debuginfo(build-id) R-V8-debugsource: R-V8-debugsource R-V8-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/iucar/fedora-review/2142712-R-V8/srpm/R-V8.spec 2022-11-30 10:14:26.752789462 +0100 +++ /home/iucar/fedora-review/2142712-R-V8/srpm-unpacked/R-V8.spec 2022-11-15 01:18:34.000000000 +0100 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.2.6) +%define autorelease(e:s:pb:) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist} +## END: Set by rpmautospec + %global packname V8 %global packver 4.2.2 @@ -89,3 +98,110 @@ %changelog -%autochangelog +* Tue Nov 15 2022 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> 4.2.2-1 +- Uncommitted changes + +* Wed Jul 20 2022 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 3.4.2-5 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + +* Wed Jan 19 2022 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 3.4.2-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + +* Wed Jul 21 2021 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 3.4.2-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + +* Thu Jun 24 2021 Stephen Gallagher <sgallagh@xxxxxxxxxx> - 3.4.2-2 +- Rebuild for Node.js 16 + +* Tue Jun 15 2021 Tom Callaway <spot@xxxxxxxxxxxxxxxxx> - 3.4.2-1 +- update to 3.4.2 +- Rebuilt for R 4.1.0 + +* Sat Apr 24 2021 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.4.1-1 +- Update to latest version (#1952839) + +* Mon Jan 25 2021 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 3.4.0-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Fri Nov 06 2020 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.4.0-1 +- Update to latest version (#1894577) + +* Mon Oct 26 2020 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.3.1-1 +- Update to latest version (#1891266) + +* Sat Sep 12 2020 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.2.0-3 +- Fix checks for pointer compression, fixing build on s390x + +* Sat Aug 01 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 3.2.0-3 +- Second attempt - Rebuilt for + https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Mon Jul 27 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 3.2.0-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Tue Jul 21 2020 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.2.0-1 +- Update to latest version + +* Wed Jul 8 2020 Dennis Gilmore <dennis@xxxxxxxx> - 3.1.0-3 +- Rebuild for nodejs deps + +* Sat Jun 6 2020 Tom Callaway <spot@xxxxxxxxxxxxxxxxx> - 3.1.0-2 +- rebuild for R 4 + +* Sun May 31 2020 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.1.0-1 +- Update to latest version + +* Sat Mar 14 2020 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.0.2-1 +- Update to latest version + +* Tue Feb 25 2020 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.0.1-2 +- Fix test on big-endian systems + +* Mon Feb 24 2020 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 3.0.1-1 +- Update to latest version + +* Tue Jan 28 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 2.3-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + +* Mon Aug 26 2019 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 2.3-1 +- Update to latest version + +* Sun Aug 11 2019 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 2.2-3 +- Remove explicit dependencies provided by automatic dependency generator + +* Wed Jul 24 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 2.2-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + +* Sat Apr 13 2019 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 2.2-1 +- Update to latest version + +* Tue Apr 09 2019 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 2.1-1 +- Update to latest version +- Switch to v8 provided by nodejs + +* Fri Feb 08 2019 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 2.0-1 +- Update to latest version + +* Thu Jan 31 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.5-8 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + +* Sun Sep 23 2018 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 1.5-7 +- Fix unbundling of JavaScript files + +* Thu Jul 12 2018 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.5-6 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild + +* Wed May 16 2018 Tom Callaway <spot@xxxxxxxxxxxxxxxxx> - 1.5-5 +- rebuild for R 3.5.0 + +* Sun Mar 18 2018 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 1.5-4 +- Add missing Rcpp Requires + +* Wed Feb 07 2018 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 1.5-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + +* Wed Jan 03 2018 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 1.5-2 +- Use jsdir macro for JavaScript files + +* Thu Nov 09 2017 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> - 1.5-1 +- initial package for Fedora + Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2142712 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic, R Disabled plugins: Java, Perl, Ocaml, PHP, Haskell, Python, fonts, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2142712 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
