https://bugzilla.redhat.com/show_bug.cgi?id=2049716 Soumil <soumilkadam@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |soumilkadam@xxxxxxxxx --- Comment #1 from Soumil <soumilkadam@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 11 files have unknown license. Detailed output of licensecheck in /home/soumil/2049716-aws-checksums/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/aws-checksums, /usr/include/aws/checksums, /usr/lib64/aws-checksums/cmake/shared, /usr/lib64/aws-checksums/cmake [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/aws/checksums, /usr/include/aws, /usr/lib64/aws-checksums/cmake/shared, /usr/lib64/aws-checksums/cmake, /usr/lib64/aws-checksums [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in aws- checksums-libs , aws-checksums-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 3.3 starting (python version = 3.10.8, NVR = mock-3.3-1.fc36)... Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 3.3 INFO: Mock Version: 3.3 Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 3.3 INFO: Mock Version: 3.3 Finish: chroot init INFO: installing package(s): /builddir/aws-checksums-libs-0.1.12-2.fc38.x86_64.rpm /builddir/aws-checksums-debugsource-0.1.12-2.fc38.x86_64.rpm /builddir/aws-checksums-libs-debuginfo-0.1.12-2.fc38.x86_64.rpm /builddir/aws-checksums-devel-0.1.12-2.fc38.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 4ff599a50ee54ac68fc2261cd5cdbbd7 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.5r9fpo8z:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 38 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /builddir/aws-checksums-libs-0.1.12-2.fc38.x86_64.rpm /builddir/aws-checksums-debugsource-0.1.12-2.fc38.x86_64.rpm /builddir/aws-checksums-libs-debuginfo-0.1.12-2.fc38.x86_64.rpm /builddir/aws-checksums-devel-0.1.12-2.fc38.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Cannot parse rpmlint output: Unversioned so-files -------------------- aws-checksums-libs: /usr/lib64/libaws-checksums.so Source checksums ---------------- https://github.com/awslabs/aws-checksums/archive/v0.1.12/aws-checksums-0.1.12.tar.gz : CHECKSUM(SHA256) this package : 394723034b81cc7cd528401775bc7aca2b12c7471c92350c80a0e2fb9d2909fe CHECKSUM(SHA256) upstream package : 394723034b81cc7cd528401775bc7aca2b12c7471c92350c80a0e2fb9d2909fe Requires -------- aws-checksums-libs (rpmlib, GLIBC filtered): aws-checksums(x86-64) libaws-c-common.so.1()(64bit) libaws-checksums.so.1.0.0()(64bit) rtld(GNU_HASH) aws-checksums-devel (rpmlib, GLIBC filtered): aws-checksums-libs(x86-64) aws-checksums-debugsource (rpmlib, GLIBC filtered): Provides -------- aws-checksums-libs: aws-checksums-libs aws-checksums-libs(x86-64) libaws-checksums.so.1.0.0()(64bit) aws-checksums-devel: aws-checksums-devel aws-checksums-devel(x86-64) aws-checksums-debugsource: aws-checksums-debugsource aws-checksums-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/soumil/2049716-aws-checksums/srpm/aws-checksums.spec 2022-11-28 13:06:50.169480600 -0500 +++ /home/soumil/2049716-aws-checksums/srpm-unpacked/aws-checksums.spec 2022-02-03 09:50:04.000000000 -0500 @@ -1,5 +1,5 @@ Name: aws-checksums Version: 0.1.12 -Release: 5%{?dist} +Release: 2%{?dist} Summary: Checksum package for AWS SDK for C @@ -7,5 +7,4 @@ URL: https://github.com/awslabs/%{name} Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz -Patch0: aws-checksums-cmake.patch BuildRequires: gcc @@ -23,5 +22,6 @@ %package libs Summary: Checksum package for AWS SDK for C - +Requires: %{name}%{?_isa} = %{version}-%{release} + %description libs Checksum package for AWS SDK for C. Contains @@ -41,5 +41,5 @@ %prep -%autosetup -p1 +%autosetup @@ -52,31 +52,21 @@ -%files libs +%files %license LICENSE %doc README.md + +%files libs +%{_libdir}/libaws-checksums.so %{_libdir}/libaws-checksums.so.1.0.0 %files devel -%dir %{_includedir}/aws/checksums %{_includedir}/aws/checksums/*.h -%dir %{_libdir}/cmake/aws-checksums -%dir %{_libdir}/cmake/aws-checksums/shared -%{_libdir}/libaws-checksums.so -%{_libdir}/cmake/aws-checksums/aws-checksums-config.cmake -%{_libdir}/cmake/aws-checksums/shared/aws-checksums-targets-noconfig.cmake -%{_libdir}/cmake/aws-checksums/shared/aws-checksums-targets.cmake +%{_libdir}/aws-checksums/cmake/aws-checksums-config.cmake +%{_libdir}/aws-checksums/cmake/shared/aws-checksums-targets-noconfig.cmake +%{_libdir}/aws-checksums/cmake/shared/aws-checksums-targets.cmake %changelog -* Tue Feb 22 2022 David Duncan <davdunc@xxxxxxxxxx> - 0.1.12-5 -- Updated for package review - -* Tue Feb 22 2022 Kyle Knapp <kyleknap@xxxxxxxxxx> - 0.1.12-4 -- Include missing devel directories - -* Thu Feb 03 2022 Kyle Knapp <kyleknap@xxxxxxxxxx> - 0.1.12-3 -- Update specfile based on review feedback - * Wed Feb 02 2022 David Duncan <davdunc@xxxxxxxxxx> - 0.1.12-2 - Prepare for package review Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2049716 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Haskell, Ocaml, PHP, SugarActivity, R, Python, Perl, Java, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2049716 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
