https://bugzilla.redhat.com/show_bug.cgi?id=2148595 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |mhroncok@xxxxxxxxxx --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: 1) Please, consider using the current Python packaging guidelines. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ The spec looks like it has been generated by rpmdev-newspec. Upstream has a pyproject template in https://pagure.io/rpmdevtools/blob/main/f/spectemplate-pyproject.spec but it has not been released yet. 2) %{?!python3_pkgversion:%global python3_pkgversion 3} This is not needed in Fedora at all. Do you intend to build the same spec file in SUSE? If not, please drop it. 3) %{?python_enable_dependency_generator} This is not needed in Fedora at all. Do you intend to build the same spec file in RHEL 8 or 7? If not, please drop it. 4) rm -rf $RPM_BUILD_ROOT This should not be needed anywhere. Please, drop it. 5) %{__python3} setup.py test This dos nothing. It says "Ran 0 tests in 0.000s" and exits cleanly. Please, make sure the tests are actually run. Consider using %pytest (and BR python3-pytest), that works. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2148595 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
