[Bug 2120131] Review Request: libgbinder - C interfaces for Android binder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2120131



--- Comment #6 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
> Version: 1.1.26

There is already a 1.1.29, can you please update?


> %description
> C interfaces for Android binder

The project has a nice README file, can you please use some text from it?


> Issues:
> =======
> - ldconfig not called in %post and %postun for Fedora 28 and later.
>   Note: /sbin/ldconfig called in libgbinder
>   See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

This is a strange issue at first sight because I can't see any
ldconfig usage in the spec file. But the fedora-review tool discovered this


    Diff spec file in url and in SRPM
    ---------------------------------
    --- /home/jkadlcik/2120131-libgbinder/srpm/libgbinder.spec  2022-11-26
13:55:19.121461294 +0100
    +++ /home/jkadlcik/2120131-libgbinder/srpm-unpacked/libgbinder.spec
2022-11-01 23:03:45.000000000 +0100
    @@ -1,2 +1,4 @@
    +%define _disable_source_fetch 0
    +
    Name: libgbinder
    Version: 1.1.26
    @@ -16,4 +18,6 @@
    BuildRequires: bison flex
    Requires: libglibutil >= %{libglibutil_version}
    +Requires(post): /sbin/ldconfig
    +Requires(postun): /sbin/ldconfig

    %description
    @@ -45,4 +49,8 @@
    %{make_build} -C unit test

    +%post -p /sbin/ldconfig
    +
    +%postun -p /sbin/ldconfig
    +
    %files
    %{_libdir}/%{name}.so.*
    @@ -55,4 +63,5 @@

    # Tools
    +
    %package tools
    Summary: Binder tools


My guess is that you updated your spec and forgot to rebuild your SRPM
file or you rebuilt the SRPM package and forgot to push the spec file
changes.


> libgbinder-tools.x86_64: W: no-manual-page-for-binary binder-bridge
> libgbinder-tools.x86_64: W: no-manual-page-for-binary binder-list
> libgbinder-tools.x86_64: W: no-manual-page-for-binary binder-ping

It would be nice to have manpages for these binaries in the
future. Can you please file an upstream RFE for them to be created,
and add the link somewhere to the spec file?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2120131
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux