https://bugzilla.redhat.com/show_bug.cgi?id=2145834 --- Comment #7 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- > > # The version used for the src tar filename can be different to the rpm version. > > # This is due to different handling of pre-release version numbers in e.g. semver, > > # rpm, dpkg. > > %global src_version 3.10.4 > > What are some example cases where this could be needed? RPM can match > upstream version, even with weird pre-release things, so it'd be best to > only have the one "Version" var. [2] > For release candidates our naming would be e.g. 'singularity-ce-3.11.0-rc.1.tar.gz'. AFAIK this needs to be RPM version 3.11.0~rc.1 so it sorts before 3.11.0. > We probably won't package any release candidates here... so I could remove it, but that would mean the spec file here differs more from the one in our source repo (which I will update after advice etc. here). If there's a strong wish to remove it, then I can. Per Fedora and EPEL update policies release candidates generally shouldn't be included in Fedora anyway. [2] Since you are the upstream here the simplest thing is "if it's suitable for Fedora then it's suitable to be an official release" thus eliminating the concern with RC versions anyway. Few more nitpicks: > W: non-conffile-in-etc /etc/bash_completion.d/singularity Bash completions are generally going in "%{_datadir}/bash-completion/completions/" these days. > W: non-standard-dir-in-var singularity Applications must generally not add directories to the top level of /var. Such directories should only be added if they have some system-wide implication, and in consultation with the FHS mailing list. [1] Perhaps /var/lib/singularity would be a better fit? === 1. https://www.pathname.com/fhs/pub/fhs-2.3.html#THEVARHIERARCHY 2. https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#stable-releases === Additionally, rpmlint is throwing the following 3 errors: singularity-ce.x86_64: E: readelf-failed /usr/bin/singularity 'utf-8' codec can't decode byte 0xc2 in position 10890: invalid continuation byte singularity-ce.x86_64: E: readelf-failed /usr/libexec/singularity/bin/starter 'utf-8' codec can't decode byte 0xc2 in position 13081: invalid continuation byte singularity-ce.x86_64: E: readelf-failed /usr/libexec/singularity/bin/starter-suid 'utf-8' codec can't decode byte 0xc2 in position 13081: invalid continuation byte I'm not really sure what to make of these. I've not seen them before and can't find a ton of docs about these errors. I'm going to continue digging and testing but I'll probably end up seeking guidance on the devel mailing list. In testing the resulting binaries all seems well. <mock-chroot> sh-5.2# readelf -h singularity ELF Header: Magic: 7f 45 4c 46 02 01 01 00 00 00 00 00 00 00 00 00 Class: ELF64 Data: 2's complement, little endian Version: 1 (current) OS/ABI: UNIX - System V ABI Version: 0 Type: DYN (Position-Independent Executable file) Machine: Advanced Micro Devices X86-64 Version: 0x1 Entry point address: 0x8e5780 Start of program headers: 64 (bytes into file) Start of section headers: 38113256 (bytes into file) Flags: 0x0 Size of this header: 64 (bytes) Size of program headers: 56 (bytes) Number of program headers: 14 Size of section headers: 64 (bytes) Number of section headers: 35 Section header string table index: 34 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2145834 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
